jdoerfert added inline comments.
================ Comment at: llvm/include/llvm/Frontend/OpenMP/OMPGridValues.h:102 + return R; + } }; ---------------- JonChesterfield wrote: > jdoerfert wrote: > > It should be in the device rtl then, no? > This header is currently used from clang and the (amdgpu, could also be cuda > if we like) host plugin. Possibly also from llvm. As of D108391 it would be > used from the devicertl. > > The idea is to have a single source of truth for the various magic numbers > that the pieces should agree on and llvm is the common point on the > dependency tree. I'm currently interested in that because I want to change > some of them for gfx10 and have that magically ripple through the components. > I'm not totally confident that will work out nicely for the host plugin as it > has to dynamically handle different architectures but I think it'll be good > enough. > > It's not totally ideal to hand spin a function that is in the math support > header but I also don't want to try to make various llvm headers > ffreestanding-safe. > It's not totally ideal to hand spin a function that is in the math support > header but I also don't want to try to make various llvm headers > ffreestanding-safe. The function is only needed in the device rtl. Put it in the device rtl. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108380/new/ https://reviews.llvm.org/D108380 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
