cor3ntin added a comment. In D108469#2957652 <https://reviews.llvm.org/D108469#2957652>, @jfb wrote:
> I worry that changing the general `static_assert` printing (adding a colon, > and dropping the quotes) will get @hwright's law to drop on us. We can try > and see if e.g. users of clang have automated checks for `static_assert` in > their CI pipelines or something. I think your new format looks better, but > Hyrum is finicky that way... What do others think? > > Can you add tests for other special characters, to make sure they're all > handled properly? Just copy/paste my twitter shitpost might be sufficient? I > think I covered all the corner cases in it, gotta be thorough! It's funny that you mention that because my code filters out LTR/RTL... I should probably change that! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108469/new/ https://reviews.llvm.org/D108469 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
