kstoimenov added a comment.
All tests are passing locally. Should be good to review now.
================
Comment at: llvm/include/llvm/Transforms/Instrumentation/AddressSanitizer.h:150
+namespace AsanAccessInfo {
+
----------------
vitalybuka wrote:
> It's not how enums described here
> https://llvm.org/docs/CodingStandards.html#id43
> Also it's common to use enum class nowerdays.
>
>
> However this one does not need to be enum and just "constexpr size_t"
I wanted to be as close as possible to the HWASan style. Please let me know if
you want me to change it.
================
Comment at: llvm/test/CodeGen/X86/asan-check-memaccess-or.ll:47
+ %2 = bitcast i64* %x to i8*
+ call void @llvm.asan.check.memaccess(i8* %2, i64 2147450880, i32 0,
+ i32 3, i32 3, i32 1)
----------------
vitalybuka wrote:
> Is this test out of date? Code has fewer arguments now.
Should be updated now.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107850/new/
https://reviews.llvm.org/D107850
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
