lebedev.ri added a comment.

In D108421#2958742 <https://reviews.llvm.org/D108421#2958742>, @kamleshbhalui 
wrote:

> assume dso local if relocation model static

I think these are two separate fixes. `TargetMachine::shouldAssumeDSOLocal()` 
change might make sense,
but as the comment there notes, this really should be fixed in in 
`CGOpenMPRuntime::getOrCreateInternalVariable()` itself (is that not the right 
default?),
and in it's every user that incorrectly unmarks said global as being `dso_local.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108421/new/

https://reviews.llvm.org/D108421

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to