cor3ntin marked 4 inline comments as done. cor3ntin added inline comments.
================ Comment at: clang/include/clang/Lex/Lexer.h:702 // Helper functions to lex the remainder of a token of the specific type. - bool LexIdentifier (Token &Result, const char *CurPtr); + bool LexIdentifierContinue(Token &Result, const char *CurPtr); bool LexNumericConstant (Token &Result, const char *CurPtr); ---------------- cor3ntin wrote: > aaron.ballman wrote: > > Should this be `LexUnicodeIdentifierContinue()`? If so, perhaps it can also > > be moved up to line 578 so it's near the "start" function? > > > > Or does this function handle both Unicode and ASCII identifiers? If so, the > > comments could probably be updated. > This handles all identifiers - after the first codepoint has been parsed - > Which comment are you referring to? I kept the comment as is - because it applies to all function underneath, but added a comment in the definition in the cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108308/new/ https://reviews.llvm.org/D108308 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits