aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
The changes LGTM, modulo a commenting request. Let's wait a bit before landing in case @rsmith has concerns. ================ Comment at: clang/include/clang/Lex/Lexer.h:702 // Helper functions to lex the remainder of a token of the specific type. - bool LexIdentifier (Token &Result, const char *CurPtr); + bool LexIdentifierContinue(Token &Result, const char *CurPtr); bool LexNumericConstant (Token &Result, const char *CurPtr); ---------------- cor3ntin wrote: > cor3ntin wrote: > > aaron.ballman wrote: > > > Should this be `LexUnicodeIdentifierContinue()`? If so, perhaps it can > > > also be moved up to line 578 so it's near the "start" function? > > > > > > Or does this function handle both Unicode and ASCII identifiers? If so, > > > the comments could probably be updated. > > This handles all identifiers - after the first codepoint has been parsed - > > Which comment are you referring to? > I kept the comment as is - because it applies to all function underneath, but > added a comment in the definition in the cpp It'd be a bit better to add the comments here; the header file is where users often first find some functionality, so that's where the comments explaining the high-level functionality of how to call the function are most useful. Also, IDEs often pick up comments "attached to" declarations and display them automatically for users which is a nice benefit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108308/new/ https://reviews.llvm.org/D108308 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
