ZarkoCA added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/AIX.cpp:237
+ addSystemInclude(DriverArgs, CC1Args, PathCPP.str());
+ CC1Args.push_back("-D__LIBC_NO_CPP_MATH_OVERLOADS__");
+ return;
----------------
Maybe a comment as to why we need this, something like:
```
// Required order to suppress conflicting C++ overloads in the system libc
headers that were used by XL C++
```
================
Comment at: clang/lib/Driver/ToolChains/AIX.cpp:240-242
+ case ToolChain::CST_Libstdcxx:
+ llvm::report_fatal_error(
+ "picking up libstdc++ headers is unimplemented on AIX");
----------------
nit: it would be my preference to have the error case first but I also that
`AIX::AddCXXStdlibLibArgs` is set up the same way so keeping them consistent
may be more important.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109078/new/
https://reviews.llvm.org/D109078
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
