SjoerdMeijer added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1646
- if (Args.getLastArg(options::OPT_mcmse))
+ bool fix_cve_2021_35465 = false;
+ if (Args.getLastArg(options::OPT_mcmse)) {
----------------
Nit: capital F in variable name.
================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1666
+ CmdArgs.push_back("-mllvm");
+ if (A->getOption().matches(options::OPT_mfix_cmse_cve_2021_35465))
+ CmdArgs.push_back("-arm-fix-cmse-cve-2021-35465=1");
----------------
I am wondering if this should use `getLastArg` and what happens with test cases
(which I guess need adding) that have both:
-mno-fix-cmse-cve-2021-35465 -mfix-cmse-cve-2021-35465
or
-mfix-cmse-cve-2021-35465 -mno-fix-cmse-cve-2021-35465
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109157/new/
https://reviews.llvm.org/D109157
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
