jsji added inline comments.
================
Comment at: clang/test/Modules/ExtDebugInfo.cpp:208
-
-// CHECK: !DIImportedEntity(tag: DW_TAG_imported_declaration, scope:
!{{[0-9]+}}, entity: ![[STRUCT]], file: ![[CPP]], line: 27)
+// CHECK: !DIImportedEntity(tag: DW_TAG_imported_declaration, scope:
!{{[0-9]+}}, entity: ![[STRUCT]], file: ![[CPP]], line: 28)
----------------
Jake-Egan wrote:
> jsji wrote:
> > Why this change? If this is needed, this should be in another patch. Thanks.
> The test failed in Debian and Windows because the unsupported line I added
> changed the expected line number: 27->28.
> https://reviews.llvm.org/D109060?id=371137
>
> Without this change, this patch would cause a regression. But, I can put it
> in another patch if that's preferred.
In that case, I would recommend we update it to regex match instead of
hardcoding line no, and yes, in another patch before this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109060/new/
https://reviews.llvm.org/D109060
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
