rsmith added inline comments.

================
Comment at: lib/Frontend/CompilerInvocation.cpp:1587-1589
@@ -1579,3 +1586,4 @@
+    .Case("cl", LangStandard::lang_opencl)
     .Case("CL1.1", LangStandard::lang_opencl11)
     .Case("CL1.2", LangStandard::lang_opencl12)
     .Case("CL2.0", LangStandard::lang_opencl20)
----------------
yaxunl wrote:
> rsmith wrote:
> > How about changing these to the lowercase form too, and treating the 
> > uppercase versions as (deprecated) synonyms? (And likewise changing 
> > LangStandards.def to list the lowercase versions, perhaps with the 
> > uppercase versions as aliases.)
> -cl-std=CL1.1|CL1.2|CL2.0 is defined by OpenCL spec. Allowing lower case may 
> cause some confusion.
> 
> -cl-std=cl is not part of OpenCL spec.
> 
> How about keeping all -cl-std= options big letters and all -std= options 
> small letters?
What? The OpenCL spec does not get to dictate our command-line argument syntax. 
If they think they do, they're just mistaken.


http://reviews.llvm.org/D20630



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to