hans accepted this revision. hans added a comment. This revision is now accepted and ready to land.
In D109828#3002495 <https://reviews.llvm.org/D109828#3002495>, @thakis wrote: > In D109828#3002114 <https://reviews.llvm.org/D109828#3002114>, @hans wrote: > >> The /winsysroot part makes sense to me, but what's the case for the new >> /diasdkdir flag? > > > > - If you do have a vcvars shell, you don't need the full sysroot path and > it's kind of useful (see example in commit message) > - it seems nice to be able to explain /winsysroot as combination of other > flags in the help text > - it makes writing the test a bit easier > - it makes diasdkdir more like the other flags controlled by /winsysroot Okay, sounds good to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109828/new/ https://reviews.llvm.org/D109828 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
