ABataev added inline comments.
================ Comment at: clang/include/clang/AST/StmtOpenMP.h:5412 + + void setIfStmt(Stmt *stmt) { IfStmt = stmt; } + Stmt *getIfStmt() const { return IfStmt; } ---------------- cchen wrote: > ABataev wrote: > > 1. Make it private, please > > 2. Var names must start from capital letter `stmt`->`S` > I'm going to fix it. By the way, do you know how to fix those failing Windows > tests? I tried to fix it by adding `ifndef HEADER` to test files and also > replace var names with regex, but those Windows tests still fail. Thanks No idea. Need a bit of context (I mean, would be good to see the test log etc.). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91944/new/ https://reviews.llvm.org/D91944 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits