quinnp created this revision.
Herald added subscribers: shchenz, kbarton, nemanjai.
quinnp requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This patch changes the signature of the load and store vector pair
builtins to match their documentation. The type of the `signed long long`
argument is changed to `signed long`. This patch also changes existing testcases
to match the signature change.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D109996
Files:
clang/include/clang/Basic/BuiltinsPPC.def
clang/test/CodeGen/builtins-ppc-pair-mma.c
clang/test/Sema/ppc-pair-mma-types.c
Index: clang/test/Sema/ppc-pair-mma-types.c
===================================================================
--- clang/test/Sema/ppc-pair-mma-types.c
+++ clang/test/Sema/ppc-pair-mma-types.c
@@ -322,16 +322,16 @@
}
void testBuiltinTypes1(const __vector_pair *vpp, const __vector_pair *vp2, float f) {
- __vector_pair vp = __builtin_vsx_lxvp(f, vpp); // expected-error {{passing 'float' to parameter of incompatible type 'long long'}}
- __builtin_vsx_stxvp(vp, 32799, vp2); // expected-error {{passing 'int' to parameter of incompatible type 'long long'}}
+ __vector_pair vp = __builtin_vsx_lxvp(f, vpp); // expected-error {{passing 'float' to parameter of incompatible type 'long'}}
+ __builtin_vsx_stxvp(vp, 32799, vp2); // expected-error {{passing 'int' to parameter of incompatible type 'long'}}
}
void testBuiltinTypes2(__vector_pair *vpp, const __vector_pair *vp2, unsigned char c) {
- __vector_pair vp = __builtin_vsx_lxvp(6LL, vpp); // expected-error {{passing '__vector_pair *' to parameter of incompatible type 'const __vector_pair *'}}
- __builtin_vsx_stxvp(vp, c, vp2); // expected-error {{passing 'unsigned char' to parameter of incompatible type 'long long'}}
+ __vector_pair vp = __builtin_vsx_lxvp(6L, vpp); // expected-error {{passing '__vector_pair *' to parameter of incompatible type 'const __vector_pair *'}}
+ __builtin_vsx_stxvp(vp, c, vp2); // expected-error {{passing 'unsigned char' to parameter of incompatible type 'long'}}
}
-void testBuiltinTypes3(vector int v, __vector_pair *vp2, signed long long ll, unsigned short s) {
- __vector_pair vp = __builtin_vsx_lxvp(ll, v); // expected-error {{passing '__vector int' (vector of 4 'int' values) to parameter of incompatible type 'const __vector_pair *'}}
- __builtin_vsx_stxvp(vp, ll, s); // expected-error {{passing 'unsigned short' to parameter of incompatible type 'const __vector_pair *'}}
+void testBuiltinTypes3(vector int v, __vector_pair *vp2, signed long l, unsigned short s) {
+ __vector_pair vp = __builtin_vsx_lxvp(l, v); // expected-error {{passing '__vector int' (vector of 4 'int' values) to parameter of incompatible type 'const __vector_pair *'}}
+ __builtin_vsx_stxvp(vp, l, s); // expected-error {{passing 'unsigned short' to parameter of incompatible type 'const __vector_pair *'}}
}
Index: clang/test/CodeGen/builtins-ppc-pair-mma.c
===================================================================
--- clang/test/CodeGen/builtins-ppc-pair-mma.c
+++ clang/test/CodeGen/builtins-ppc-pair-mma.c
@@ -1049,8 +1049,8 @@
// CHECK-NEXT: ret void
//
void test66(const __vector_pair *vpp, const __vector_pair *vp2) {
- __vector_pair vp = __builtin_vsx_lxvp(0LL, vpp);
- __builtin_vsx_stxvp(vp, 0LL, vp2);
+ __vector_pair vp = __builtin_vsx_lxvp(0L, vpp);
+ __builtin_vsx_stxvp(vp, 0L, vp2);
}
// CHECK-LABEL: @test67(
@@ -1063,7 +1063,7 @@
// CHECK-NEXT: tail call void @llvm.ppc.vsx.stxvp(<256 x i1> [[TMP2]], i8* [[TMP4]])
// CHECK-NEXT: ret void
//
-void test67(const __vector_pair *vpp, signed long long offset, const __vector_pair *vp2) {
+void test67(const __vector_pair *vpp, signed long offset, const __vector_pair *vp2) {
__vector_pair vp = __builtin_vsx_lxvp(offset, vpp);
__builtin_vsx_stxvp(vp, offset, vp2);
}
@@ -1079,8 +1079,8 @@
// CHECK-NEXT: ret void
//
void test68(const __vector_pair *vpp, const __vector_pair *vp2) {
- __vector_pair vp = __builtin_vsx_lxvp(18LL, vpp);
- __builtin_vsx_stxvp(vp, 18LL, vp2);
+ __vector_pair vp = __builtin_vsx_lxvp(18L, vpp);
+ __builtin_vsx_stxvp(vp, 18L, vp2);
}
// CHECK-LABEL: @test69(
@@ -1094,8 +1094,8 @@
// CHECK-NEXT: ret void
//
void test69(const __vector_pair *vpp, const __vector_pair *vp2) {
- __vector_pair vp = __builtin_vsx_lxvp(1LL, vpp);
- __builtin_vsx_stxvp(vp, 1LL, vp2);
+ __vector_pair vp = __builtin_vsx_lxvp(1L, vpp);
+ __builtin_vsx_stxvp(vp, 1L, vp2);
}
// CHECK-LABEL: @test70(
@@ -1109,8 +1109,8 @@
// CHECK-NEXT: ret void
//
void test70(const __vector_pair *vpp, const __vector_pair *vp2) {
- __vector_pair vp = __builtin_vsx_lxvp(42LL, vpp);
- __builtin_vsx_stxvp(vp, 42LL, vp2);
+ __vector_pair vp = __builtin_vsx_lxvp(42L, vpp);
+ __builtin_vsx_stxvp(vp, 42L, vp2);
}
// CHECK-LABEL: @test71(
@@ -1124,8 +1124,8 @@
// CHECK-NEXT: ret void
//
void test71(const __vector_pair *vpp, const __vector_pair *vp2) {
- __vector_pair vp = __builtin_vsx_lxvp(32768LL, vpp);
- __builtin_vsx_stxvp(vp, 32768LL, vp2);
+ __vector_pair vp = __builtin_vsx_lxvp(32768L, vpp);
+ __builtin_vsx_stxvp(vp, 32768L, vp2);
}
// CHECK-LABEL: @test72(
@@ -1139,8 +1139,8 @@
// CHECK-NEXT: ret void
//
void test72(const __vector_pair *vpp, const __vector_pair *vp2) {
- __vector_pair vp = __builtin_vsx_lxvp(32799LL, vpp);
- __builtin_vsx_stxvp(vp, 32799LL, vp2);
+ __vector_pair vp = __builtin_vsx_lxvp(32799L, vpp);
+ __builtin_vsx_stxvp(vp, 32799L, vp2);
}
// CHECK-LABEL: @test73(
@@ -1157,7 +1157,7 @@
//
void test73(unsigned char *vqp, const __vector_pair *vpp, vector unsigned char vc, unsigned char *resp) {
__vector_quad vq = *((__vector_quad *)vqp);
- __vector_pair vp = __builtin_vsx_lxvp(8LL, vpp);
+ __vector_pair vp = __builtin_vsx_lxvp(8L, vpp);
__builtin_mma_pmxvf64gernn(&vq, vp, vc, 0, 0);
*((__vector_quad *)resp) = vq;
}
@@ -1175,7 +1175,7 @@
//
void test74(unsigned char *vqp, const __vector_pair *vpp, vector unsigned char vc, unsigned char *resp) {
__vector_quad vq = *((__vector_quad *)vqp);
- __vector_pair vp = __builtin_vsx_lxvp(0LL, vpp);
+ __vector_pair vp = __builtin_vsx_lxvp(0L, vpp);
__builtin_mma_xvf64gernp(&vq, vp, vc);
*((__vector_quad *)resp) = vq;
}
@@ -1192,7 +1192,7 @@
// CHECK-NEXT: store <512 x i1> [[TMP5]], <512 x i1>* [[TMP6]], align 64, !tbaa [[TBAA2]]
// CHECK-NEXT: ret void
//
-void test75(unsigned char *vqp, signed long long offs, const __vector_pair *vpp, vector unsigned char vc, unsigned char *resp) {
+void test75(unsigned char *vqp, signed long offs, const __vector_pair *vpp, vector unsigned char vc, unsigned char *resp) {
__vector_quad vq = *((__vector_quad *)vqp);
__vector_pair vp = __builtin_vsx_lxvp(offs, vpp);
__builtin_mma_xvf64gernp(&vq, vp, vc);
@@ -1241,8 +1241,8 @@
// CHECK-NEXT: ret void
//
void test78(const __vector_pair *vpp, const __vector_pair *vp2) {
- __vector_pair vp = __builtin_mma_lxvp(0LL, vpp);
- __builtin_mma_stxvp(vp, 0LL, vp2);
+ __vector_pair vp = __builtin_mma_lxvp(0L, vpp);
+ __builtin_mma_stxvp(vp, 0L, vp2);
}
// CHECK-LABEL: @test79(
@@ -1255,7 +1255,7 @@
// CHECK-NEXT: tail call void @llvm.ppc.vsx.stxvp(<256 x i1> [[TMP2]], i8* [[TMP4]])
// CHECK-NEXT: ret void
//
-void test79(const __vector_pair *vpp, signed long long offset, const __vector_pair *vp2) {
+void test79(const __vector_pair *vpp, signed long offset, const __vector_pair *vp2) {
__vector_pair vp = __builtin_mma_lxvp(offset, vpp);
__builtin_mma_stxvp(vp, offset, vp2);
}
@@ -1271,8 +1271,8 @@
// CHECK-NEXT: ret void
//
void test80(const __vector_pair *vpp, const __vector_pair *vp2) {
- __vector_pair vp = __builtin_mma_lxvp(18LL, vpp);
- __builtin_mma_stxvp(vp, 18LL, vp2);
+ __vector_pair vp = __builtin_mma_lxvp(18L, vpp);
+ __builtin_mma_stxvp(vp, 18L, vp2);
}
// CHECK-LABEL: @test81(
@@ -1286,8 +1286,8 @@
// CHECK-NEXT: ret void
//
void test81(const __vector_pair *vpp, const __vector_pair *vp2) {
- __vector_pair vp = __builtin_mma_lxvp(1LL, vpp);
- __builtin_mma_stxvp(vp, 1LL, vp2);
+ __vector_pair vp = __builtin_mma_lxvp(1L, vpp);
+ __builtin_mma_stxvp(vp, 1L, vp2);
}
// CHECK-LABEL: @test82(
@@ -1301,8 +1301,8 @@
// CHECK-NEXT: ret void
//
void test82(const __vector_pair *vpp, const __vector_pair *vp2) {
- __vector_pair vp = __builtin_mma_lxvp(42LL, vpp);
- __builtin_mma_stxvp(vp, 42LL, vp2);
+ __vector_pair vp = __builtin_mma_lxvp(42L, vpp);
+ __builtin_mma_stxvp(vp, 42L, vp2);
}
// CHECK-LABEL: @test83(
@@ -1316,8 +1316,8 @@
// CHECK-NEXT: ret void
//
void test83(const __vector_pair *vpp, const __vector_pair *vp2) {
- __vector_pair vp = __builtin_mma_lxvp(32768LL, vpp);
- __builtin_mma_stxvp(vp, 32768LL, vp2);
+ __vector_pair vp = __builtin_mma_lxvp(32768L, vpp);
+ __builtin_mma_stxvp(vp, 32768L, vp2);
}
// CHECK-LABEL: @test84(
@@ -1331,8 +1331,8 @@
// CHECK-NEXT: ret void
//
void test84(const __vector_pair *vpp, const __vector_pair *vp2) {
- __vector_pair vp = __builtin_mma_lxvp(32799LL, vpp);
- __builtin_mma_stxvp(vp, 32799LL, vp2);
+ __vector_pair vp = __builtin_mma_lxvp(32799L, vpp);
+ __builtin_mma_stxvp(vp, 32799L, vp2);
}
// CHECK-LABEL: @test85(
@@ -1349,7 +1349,7 @@
//
void test85(unsigned char *vqp, const __vector_pair *vpp, vector unsigned char vc, unsigned char *resp) {
__vector_quad vq = *((__vector_quad *)vqp);
- __vector_pair vp = __builtin_mma_lxvp(8LL, vpp);
+ __vector_pair vp = __builtin_mma_lxvp(8L, vpp);
__builtin_mma_pmxvf64gernn(&vq, vp, vc, 0, 0);
*((__vector_quad *)resp) = vq;
}
@@ -1367,7 +1367,7 @@
//
void test86(unsigned char *vqp, const __vector_pair *vpp, vector unsigned char vc, unsigned char *resp) {
__vector_quad vq = *((__vector_quad *)vqp);
- __vector_pair vp = __builtin_mma_lxvp(0LL, vpp);
+ __vector_pair vp = __builtin_mma_lxvp(0L, vpp);
__builtin_mma_xvf64gernp(&vq, vp, vc);
*((__vector_quad *)resp) = vq;
}
@@ -1384,7 +1384,7 @@
// CHECK-NEXT: store <512 x i1> [[TMP5]], <512 x i1>* [[TMP6]], align 64, !tbaa [[TBAA2]]
// CHECK-NEXT: ret void
//
-void test87(unsigned char *vqp, signed long long offs, const __vector_pair *vpp, vector unsigned char vc, unsigned char *resp) {
+void test87(unsigned char *vqp, signed long offs, const __vector_pair *vpp, vector unsigned char vc, unsigned char *resp) {
__vector_quad vq = *((__vector_quad *)vqp);
__vector_pair vp = __builtin_mma_lxvp(offs, vpp);
__builtin_mma_xvf64gernp(&vq, vp, vc);
Index: clang/include/clang/Basic/BuiltinsPPC.def
===================================================================
--- clang/include/clang/Basic/BuiltinsPPC.def
+++ clang/include/clang/Basic/BuiltinsPPC.def
@@ -813,8 +813,8 @@
// its given accumulator.
// Provided builtins with _mma_ prefix for compatibility.
-CUSTOM_BUILTIN(mma_lxvp, vsx_lxvp, "W256SLLiW256C*", false)
-CUSTOM_BUILTIN(mma_stxvp, vsx_stxvp, "vW256SLLiW256C*", false)
+CUSTOM_BUILTIN(mma_lxvp, vsx_lxvp, "W256SLiW256C*", false)
+CUSTOM_BUILTIN(mma_stxvp, vsx_stxvp, "vW256SLiW256C*", false)
CUSTOM_BUILTIN(mma_assemble_pair, vsx_assemble_pair, "vW256*VV", false)
CUSTOM_BUILTIN(mma_disassemble_pair, vsx_disassemble_pair, "vv*W256*", false)
@@ -823,8 +823,8 @@
// ID and INTR are the same.
// This avoids repeating the ID and INTR in the macro expression.
-UNALIASED_CUSTOM_BUILTIN(vsx_lxvp, "W256SLLiW256C*", false)
-UNALIASED_CUSTOM_BUILTIN(vsx_stxvp, "vW256SLLiW256C*", false)
+UNALIASED_CUSTOM_BUILTIN(vsx_lxvp, "W256SLiW256C*", false)
+UNALIASED_CUSTOM_BUILTIN(vsx_stxvp, "vW256SLiW256C*", false)
UNALIASED_CUSTOM_BUILTIN(vsx_assemble_pair, "vW256*VV", false)
UNALIASED_CUSTOM_BUILTIN(vsx_disassemble_pair, "vv*W256*", false)
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
