HazardyKnusperkeks added inline comments.
================ Comment at: clang/lib/Format/QualifierAlignmentFixer.cpp:449 + return false; + if (Tok->is(TT_TypenameMacro)) + return false; ---------------- I think this is still right, because it is a type (according to the configuration). ================ Comment at: clang/lib/Format/QualifierAlignmentFixer.h:16 + +#ifndef LLVM_CLANG_LIB_FORMAT_LeftRightQualifierAlignmentFixer_H +#define LLVM_CLANG_LIB_FORMAT_LeftRightQualifierAlignmentFixer_H ---------------- This clang-tidy isn't addressed. ================ Comment at: clang/unittests/Format/QualifierFixerTest.cpp:122 + +}; // namespace + ---------------- In addition to clang-tidies message: It is unnecessary. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D69764 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits