paulwalker-arm added inline comments.
================ Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1850 + else + TuneCPU = "generic"; + } else ---------------- What benefit does `-tune-cpu generic` provide? I'm wondering if the patch can be restricted to only add `-tune-cpu` when a `-mtune=` is specified with a real name or a detected name for when "native" is specified. ================ Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1857-1860 + else if (!Args.getLastArg(clang::driver::options::OPT_mcpu_EQ)) { + CmdArgs.push_back("-tune-cpu"); + CmdArgs.push_back("generic"); + } ---------------- See me comment above. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110258/new/ https://reviews.llvm.org/D110258 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits