khchen accepted this revision. khchen added a comment. This revision is now accepted and ready to land.
LGTM. ================ Comment at: clang/include/clang/Basic/riscv_vector.td:2186 +}] in +def policy : RVVHeader; ---------------- HsiangKai wrote: > khchen wrote: > > It seems like we can rewrite `vsetvli/vsetvl` and ` vsetvlmax` instructions > > by using the `RVVHeader` mechanism? > > We only need to have one mechanism to dump header code. > Should we create `vsetvli/vsetvlmax` builtins? If we should, we may not be > able to use `RVVHeader` for these intrinsics. oh, you are right. I forget that. Could you please move class definition in top of this file due to all class centralized there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109322/new/ https://reviews.llvm.org/D109322 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
