arsenm added inline comments.

================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUResourceUsageAnalysis.cpp:65
 
-  return cast<Function>(Op.getGlobal());
+  return dyn_cast<Function>(Op.getGlobal());
 }
----------------
I think this is not the right place for this. If we can determine the callee 
function, we should have directly set it in the instruction during call lowering


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109707/new/

https://reviews.llvm.org/D109707

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to