MaskRay added inline comments.

================
Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:581
+      CmdArgs.push_back("--push-state");
+      CmdArgs.push_back("--as-needed");
       if (OnlyLibstdcxxStatic)
----------------
MaskRay wrote:
> The --as-needed change should be dropped from this patch.
> 
`--push-state` should only be added when -Bstatic is added.

Then the old clang-ppc64le-rhel issue may be moot because they probably don't 
use -static-libstdc++ ...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110128/new/

https://reviews.llvm.org/D110128

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to