cor3ntin added inline comments.

================
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:5942
   "jump bypasses initialization of VLA type alias">;
 def note_protected_by_constexpr_if : Note<
   "jump enters controlled statement of constexpr if">;
----------------
erichkeane wrote:
> Oh boy.... this section of 'notes' seem like they deserve some level of 
> merging with a %select.  I'd not want anything other than the `jump enters 
> controlled statemennt of `  variants for this patch though.
I don't think we can change that without some more refactor.
see usages of `note_protected_by_constexpr_if`.
The Diag ID is passed to a `GotoScope` emitting later. No way to pass 
parameter. Changing that would be unrelated to this PR


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110482/new/

https://reviews.llvm.org/D110482

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to