hans added a comment. Nice!
================ Comment at: clang/lib/Basic/CLWarnings.cpp:17 + switch (CLWarningID) { + case 4005: return "macro-redefined"; + case 4018: return "sign-compare"; ---------------- Would it be possible to reference the DiagGroup symbolically here somehow instead of using a string? That way, if the DiagGroup gets renamed, we don't risk forgetting to update this string. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110668/new/ https://reviews.llvm.org/D110668 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits