xbolva00 marked 3 inline comments as done. xbolva00 added inline comments.
================ Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:69 def note_cast_to_void : Note<"cast expression to void to silence warning">; +def note_cast_operand_to_int : Note<"cast one or both operands to int to silence warning">; ---------------- Quuxplusone wrote: > LGTM, based on the precedent set on line 68. If I were writing all these > notes from scratch, I'd say "to silence //this// warning"; but that can be > done in a separate PR, if ever. Yeah, silence this warning is better and also used (well, more often) in this file. I will change it to this form. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108003/new/ https://reviews.llvm.org/D108003 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
