atanasyan accepted this revision. atanasyan added a comment. This revision is now accepted and ready to land.
LGTM with some nits ================ Comment at: lib/Driver/Tools.cpp:1446 @@ +1445,3 @@ + CmdArgs.push_back(Args.MakeArgString("-mips-compact-branches=" + Val)); + + } else ---------------- Redundant empty line. ================ Comment at: lib/Driver/Tools.cpp:7084 @@ +7083,3 @@ + // mips32r6 and mips64r6 have compact branches. + + return (bool)llvm::StringSwitch<int>(CPU) ---------------- Redundant empty line. ================ Comment at: lib/Driver/Tools.cpp:7085 @@ +7084,3 @@ + + return (bool)llvm::StringSwitch<int>(CPU) + .Case("mips32r6", true) ---------------- Is it possible to re-write this line as: ``` return llvm::StringSwitch<bool>(CPU) ``` http://reviews.llvm.org/D20729 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits