aaron.ballman added a comment.
Btw, this CI failure looks relevant:
https://reviews.llvm.org/harbormaster/unit/view/1055822/ but... it looks more
relevant to the parent patch than this one (and the parent seems to have a
clean CI). May be worth looking into whether this is an issue or not.
================
Comment at: clang/lib/Basic/Diagnostic.cpp:820
+ }
+ std::string number;
+ {
----------------
================
Comment at: clang/lib/Basic/Diagnostic.cpp:822
+ {
+ llvm::raw_string_ostream stream(number);
+ stream << "<U+" << llvm::format_hex_no_prefix(CodepointValue, 4, true)
----------------
================
Comment at: clang/lib/Basic/Diagnostic.cpp:829-830
+ }
+ SmallString<16> expandedByte("<XX>");
+ unsigned char byte = *Begin;
+ expandedByte[1] = llvm::hexdigit(byte / 16);
----------------
================
Comment at: llvm/include/llvm/Support/Unicode.h:37
+// Formatting codepoints are codepoints in the category Cf
+bool isFormatting(int UCS);
----------------
================
Comment at: llvm/lib/Support/Unicode.cpp:271
- return UCS >= 0 && UCS <= 0x10FFFF && !NonPrintables.contains(UCS);
+/// Unicode code points of the category Cf are considered
+/// fornatting characters.
----------------
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108469/new/
https://reviews.llvm.org/D108469
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
