shafik added inline comments.
================
Comment at: clang/lib/AST/ASTImporter.cpp:8456
class AttrImporter {
- Error Err = Error::success();
+ Error &Err;
ASTImporter &Importer;
----------------
I am enthusiastic about reference members if we can somehow avoid them.
Can we use a struct to return both the `Err` and the pointer together? I don't
like `std::pair` mainly b/c `first` and `second` are not meaningful.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110810/new/
https://reviews.llvm.org/D110810
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
