aaron.ballman added inline comments.
================ Comment at: clang/test/Sema/MicrosoftExtensions.cpp:9-10 + return (p32u == p32s) + + (p32u == p64) + + (p32s == p64); +} ---------------- akhuang wrote: > aaron.ballman wrote: > > (Side question, not directly about this patch but sorta related.) Should > > there be a diagnostic about conversion potentially causing a possible loss > > of data (on the 64-bit target)? > Hmm, it seems reasonable, but I also don't know how motivated I am to add a > diagnostic -- I don't insist -- we are missing that warning in general here (we don't warn on assignment yet). But it might be a nice follow-up for anyone who's interested in working on it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110670/new/ https://reviews.llvm.org/D110670 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
