aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed.
In D111041#3039590 <https://reviews.llvm.org/D111041#3039590>, @carlosgalvezp wrote: > I wonder why I'm not getting automated pre-merge builds? Huh, that is strange. Usually you get them automatically when you set the Repository properly (which it looks like you have). This change is missing documentation changes, release note mentions, test coverage, etc, so it needs a bit of work in those areas. However, more importantly, do you have evidence that this option is not being used by users? I understand that the core guidelines changed their position on this feature and so we may want to change the default value, but removing the option entirely feels user-hostile without some evidence that this option is unused in practice. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111041/new/ https://reviews.llvm.org/D111041 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
