usaxena95 marked an inline comment as done.
usaxena95 added inline comments.
================
Comment at: clang-tools-extra/clangd/XRefs.cpp:1397
+ OverriddenBy.Subjects.insert(ID);
getOverriddenMethods(CMD, OverriddenMethods);
}
----------------
kadircet wrote:
> note that there's a behaviour change here as well. not sure how often it
> matters in practice, but previously we would still get the overriden methods
> for a symbol even if we fail to generate symbolid for it. let's keep it the
> same.
Hmm. You are right. Even in `getOverriddenMethods` we find the symbolID
*optionally* and we always traverse the complete type hierarchy. Let's do the
same here for consistency.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111039/new/
https://reviews.llvm.org/D111039
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
