mstorsjo added a subscriber: rnk. mstorsjo added a comment. This looks ok to me I guess. Technically in this case, this is pretty much equivalent to `#ifdef _WIN32`, i.e. any form when running on windows, where the process considers itself windows (cygwin doesn't define `_WIN32`), but I guess keeping it based on `getProcessTriple()` is fine too.
I'll leave it open for discussion for a while, but if there's no further opinions I can accept it later. @rnk Do you happen to have any experience here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111195/new/ https://reviews.llvm.org/D111195 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
