Ericson2314 added inline comments.
================ Comment at: llvm/tools/llvm-config/llvm-config.cpp:361 + { + SmallString<256> Path(StringRef(LLVM_INSTALL_INCLUDEDIR)); + sys::fs::make_absolute(ActivePrefix, Path); ---------------- Ericson2314 wrote: > Ericson2314 wrote: > > compnerd wrote: > > > Why the temporary `StringRef`? Can you not just initialize `Path` with > > > the literal? > > I'm not sure. I would think so too, but the old code was also using > > `StringRef` so I just followed cargo culted and went with it. > Should I, say, submit a separate patch trying to remove the existing one? I opened D111322 for this. If that passes CI and lands, I have the next version of this without `StringRef` ready to go. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100810/new/ https://reviews.llvm.org/D100810 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits