ASDenysPetrov added inline comments.
================ Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:2104 + const llvm::APSInt &SV = CI->getValue(); + const RangeSet *ClassConstraint = getConstraint(State, Class); + // We have found a contradiction. ---------------- We usually use `R` or `RS`. It gets readability better IMO. ================ Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:2107-2109 + return nullptr; + } else { + SimplifiedMemberSym = SimplifiedMemberVal.getAsSymbol(); ---------------- What prevents you to not put this stuff inside `ento::simplify`. I think it should perfectly fit in there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110913/new/ https://reviews.llvm.org/D110913 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits