lenary added a comment.

In D109825#3055142 <https://reviews.llvm.org/D109825#3055142>, @xgupta wrote:

> It misses llvm/test/CodeGen/AArch64 and llvm/test/MC/AArch64 testcases 
> changes, see for example https://reviews.llvm.org/D36667 (Cortex-A55 support).

I'm not convinced this is required - those tests are to ensure that the 
extensions (rcpc, dotprod) can be enabled either from a `-march`, or from a 
`-mcpu=<cpu>` with a cpu that contains that extension -- they are not testing 
that the extension is enabled from *all* cpus that contain said extension.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109825/new/

https://reviews.llvm.org/D109825

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to