dmgreen added a comment. If D111551 <https://reviews.llvm.org/D111551> was folded into this patch, would it be possible to add tests for -tune-cpu enabling/disabling features at the correct times?
================ Comment at: clang/test/Driver/aarch64-mtune.c:3 + +// There shouldn't be a default -mtune. +// RUN: %clang -target aarch64-unknown-unknown -c -### %s 2>&1 \ ---------------- Why do we not want to add a default tune-cpu? ================ Comment at: clang/test/Driver/aarch64-mtune.c:34 + +// RUN: %clang -target aarch64-unknown-unknown -c -### %s -mcpu=thunderx 2>&1 \ +// RUN: | FileCheck %s -check-prefix=mcputhunderx ---------------- My understanding is that -mcpu=cpu is the same as -march=something + -mtune=cpu. Why would this case not add a -tune-cpu too? Is it because that gets handled in llvm? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110258/new/ https://reviews.llvm.org/D110258 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
