dexonsmith added a comment.
In D111560#3055578 <https://reviews.llvm.org/D111560#3055578>, @jansvoboda11
wrote:
> Note: Another approach to fixing this might be to cache the module load
> results while loading the PCH too.
Can you share why you chose this approach instead, and which do you think makes
sense long term?
================
Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningTool.cpp:41
for (const PrebuiltModuleDep &PMD : PrebuiltModuleDeps) {
- Args.push_back("-fmodule-file=" + PMD.ModuleName + "=" + PMD.PCMFile);
+ Args.push_back("-fmodule-file=" + PMD.PCMFile);
Args.push_back("-fmodule-map-file=" + PMD.ModuleMapFile);
----------------
Why drop the `<name>=` argument? Isn't it better to keep that information,
rather than forcing the reader to crack open the file to know what's inside?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111560/new/
https://reviews.llvm.org/D111560
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
