aaron.ballman added a comment.
Thank you for the fix to this!
================
Comment at: clang/lib/Analysis/CFG.cpp:2418-2420
+ // also no children, and omit the others. None of the other current StmtAttrs
+ // have semantic meaning for the CFG.
+ if (isFallthroughStatement(A) && asc.alwaysAdd(*this, A)) {
----------------
What about `OpenCLUnrollHintAttr`, `NoMergeAttr`, and `MustTailAttr`? These all
have some semantic effect as statement attributes in terms of changing codegen,
but perhaps they don't need modelling in the CFG?
(I'm trying to decide whether we may want to tablegen this functionality and so
we might want something more general than `isFallthroughStatement()`.)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111568/new/
https://reviews.llvm.org/D111568
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
