[PATCH] D111734: [HIP] Relax conditions for address space cast in builtin args

[Yaxun Liu via Phabricator via cfe-commits]

yaxunl added a comment.

we need a codegen test for the case



================
Comment at: clang/lib/Sema/SemaExpr.cpp:6550
         // type to a default address space pointee type
-        if (ArgAS != LangAS::Default || ParamAS == LangAS::Default)
           continue;
----------------
we still need to keep this condition so it should be:


```
if ((ArgAS != LangAS::Default &&
        getASTContext().getTargetAddressSpace(ArgAS) !=
        getASTContext().getTargetAddressSpace(ParamAS))
   || ParamAS == LangAS::Default)
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111734/new/

https://reviews.llvm.org/D111734

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits