Anastasia added a comment. In D110618#3054257 <https://reviews.llvm.org/D110618#3054257>, @pekka.jaaskelainen wrote:
>> I don't feel it is different for OpenCL though... I am not in favour of >> repeating the same functionality for every language since the requirement >> will be likely identical. There is no timeline for when this functionality >> will be dropped so we have to assume that even though temporary it might be >> a solution for long enough. > > If it is likely the SPIR-V backend won’t land soon and it is expected that > also other languages might benefit from the calls to the llvm-spirv tool, the > functionality to do so would be better placed in a more generally useful > place. Do you have suggestions where this functionality could be moved? > > I believe it concerns mostly the call to the llvm-spriv (this is sought in > PATH, not given via a command line parameter) inside > constructEmitSpirvCommand(). This could be extracted to another function in a > utility library so it could be accessed by other languages/tools in the > future. Does it sound OK? I believe this is indeed the most common functionality at this point, so if we could factor it out already now it would make sense. However, towards the common tooling we would probably need to create a special Tool/ToolChain for SPIR-V which could be derived from or used for the languages/toochains that target SPIR-V generation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110618/new/ https://reviews.llvm.org/D110618 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
