JDevlieghere added inline comments.
================
Comment at: llvm/lib/Support/VirtualFileSystem.cpp:1179-1180
+ if (ExternalFS)
+ ExternalFS->setCurrentWorkingDirectory(Path);
+
----------------
I'm pretty sure there was a reason we stopped doing this. There should be some
discussion about that in my original patch.
================
Comment at: llvm/lib/Support/VirtualFileSystem.cpp:2012
+ if (auto Result = ExternalFS->status(CanonicalPath)) {
+ return Result.get().copyWithNewName(Result.get(), OriginalPath);
+ } else {
----------------
Can we abstract this in a function similar to `getRedirectedFileStatus`,
something like `getOrginialFileStatus` or `getNonCanonicalizedFileStatus` and
have a comment explaining what it does and why?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109128/new/
https://reviews.llvm.org/D109128
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
