sbenza added inline comments.
================
Comment at: clang-tidy/performance/UnnecessaryValueParamCheck.cpp:34
@@ -29,1 +33,3 @@
+template <typename S> bool isSetDifferenceEmpty(const S &S1, const S &S2) {
+ for (const auto &E : S1)
----------------
isSubset?
================
Comment at: clang-tidy/utils/Matchers.cpp:16
@@ +15,3 @@
+
+ast_matchers::TypeMatcher isConstReference() {
+ return ast_matchers::referenceType(ast_matchers::pointee(
----------------
Prefer AST_MATCHER_FUNCTION.
That macro will make sure to use a singleton matcher instead, since it has no
arguments.
================
Comment at: clang-tidy/utils/Matchers.h:44
@@ +43,3 @@
+// Returns QualType matcher for references to const.
+ast_matchers::TypeMatcher isConstReference();
+
----------------
isReferenceToConst
http://reviews.llvm.org/D20277
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
