sammccall added inline comments.
================
Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:292
auto Refs = findReferencedLocations(AST);
auto ReferencedFiles = translateToHeaderIDs(findReferencedFiles(Refs, SM),
AST.getIncludeStructure(), SM);
----------------
sammccall wrote:
> while here, pull out findReferencedFiles into its own var, and leave a FIXME
> to adjust the set of referenced files to account for non-self-contained
> headers whose symbols can be attributed to their include parents
Sorry, this was meant to be an optional suggestion rather than an angry command
:-)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112695/new/
https://reviews.llvm.org/D112695
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
