aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed.
`swift_attr` has no subjects, so this will attempt to spray the attribute onto literally *everything*. That makes this incredibly risky to use with the pragma approach (not to mention what it could do to memory consumption of large ASTs). I'm not certain I'm comfortable allowing this without an explicit set of subjects for the attribute. I took a look and the only other attribute currently allowed there is `annotate`, and I'm not convinced that was a good idea to allow for use in this pragma. Can we add subjects to this attribute to try to limit the damage somewhat? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112773/new/ https://reviews.llvm.org/D112773 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
