stuij marked 6 inline comments as done. stuij added a comment. A slight amendment to the description of the just uploaded patch amendment: PACG has also been made conditional.
================ Comment at: llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp:6441 + Mnemonic == "csetm" || + Mnemonic == "autg" || Mnemonic == "aut" || + Mnemonic == "bxaut" || Mnemonic == "pacg" || Mnemonic == "pac" || ---------------- ostannard wrote: > PACG, AUTG and BXAUT can be conditional, so shouldn't be in this list. Thanks. Besides removing these from this list and the one below, I've added a predicate operator to actually make them conditional. The description of the patch amend didn't mention PACG, but it too has been made conditional. ================ Comment at: llvm/test/MC/ARM/armv8.1m-pacbti-error.s:3 + +// CHECK: error: invalid instruction +pac r0, r1, r2 ---------------- ostannard wrote: > We should also test the cases where PACG/AUTG/BXAUT cannot use PC/SP. Thanks. Adding extra testcases uncovered a number of cases where the changes didn't match the spec. This should now be resolved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112420/new/ https://reviews.llvm.org/D112420 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
