eopXD added a comment. @asb Thanks for the reply.
To clarify the question, the 2 inconsistencies are: - Test cases with `clang -cc1` originally don't do dependency check to target feature specified (handled by `parseFeatures`) - Clang driver's -march enforces version to be specified, while llvm allows `.attribute` arch to not specify version (and picks the default one) What this patch tries to do, letting the 2 actions (`parseFeatures` and `parseArchString`) rely on the same function call will mean to alter the behavior on one of them. In my humble opinion, it is rather awkward to make this patch an NFC will unifying the logics of them. Maybe we can first come to a conclusion on how do we unify and then implement them in this patch. The main intentions of unifying them is that there will be some implications and dependency checks on the addition of zve and zvl, so unifying the logics will make the addition have less code duplication. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112359/new/ https://reviews.llvm.org/D112359 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
