steakhal accepted this revision.
steakhal added a comment.
This revision is now accepted and ready to land.
Yey, it looks good.
================
Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1608
LLVM_NODISCARD static ProgramStateRef
- assign(ProgramStateRef State, RangeConstraintManager &RCM,
- SValBuilder &Builder, RangeSet::Factory &F, ClassOrSymbol CoS,
- RangeSet NewConstraint) {
+ assign(ProgramStateRef State, SValBuilder &Builder, RangeSet::Factory &F,
+ ClassOrSymbol CoS, RangeSet NewConstraint) {
----------------
It seems odd, that sometimes it's called `Builder` and more frequently simply
`SVB`.
We should consider consolidating this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113261/new/
https://reviews.llvm.org/D113261
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
