AsafBadouh accepted this revision.
AsafBadouh added a comment.
This revision is now accepted and ready to land.
minor fixes, LGTM
================
Comment at: lib/Headers/avx512fintrin.h:3658
@@ +3657,3 @@
+ _mm256_undefined_si256 (),\
+ -1);\
+})
----------------
please add (__mmask16)
================
Comment at: lib/Headers/avx512fintrin.h:3669
@@ +3668,3 @@
+#define _mm512_maskz_cvt_roundps_ph( __W, __A, __I) __extension__ ({ \
+__builtin_ia32_vcvtps2ph512_mask ((__v16sf)( __A),\
+ ( __I),\
----------------
please add casting to return type (__m256i)
same for the rest
================
Comment at: test/CodeGen/avx512f-builtins.c:3121
@@ +3120,3 @@
+ // CHECK: @llvm.x86.avx512.mask.cvttps2udq.512
+
+ return _mm512_mask_cvtt_roundps_epu32(__W, __U, __A,
_MM_FROUND_CUR_DIRECTION);
----------------
remove empty line
================
Comment at: test/CodeGen/avx512f-builtins.c:3129
@@ +3128,3 @@
+ // CHECK: @llvm.x86.avx512.mask.cvttps2udq.512
+
+ return _mm512_maskz_cvtt_roundps_epu32(__U, __A, _MM_FROUND_CUR_DIRECTION);
----------------
remove empty line
http://reviews.llvm.org/D20810
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
