silvas accepted this revision. silvas added a comment. This revision is now accepted and ready to land.
Nice :) This looks pretty straightforward, but given how core this is, wait for another approver or two. ================ Comment at: llvm/include/llvm/ADT/DenseMapInfo.h:42 -template<typename T> -struct DenseMapInfo { +template <typename T, typename Enable = void> struct DenseMapInfo { //static inline T getEmptyKey(); ---------------- bondhugula wrote: > A code comment here? +1. Is there a doc that needs to be updated too? We should update the source of truth is for "here's how to use DenseMapInfo", if such documentation even exists :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113641/new/ https://reviews.llvm.org/D113641 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits