vsapsai added inline comments.
================ Comment at: clang/test/Modules/missing-submodule.m:3 // RUN: %clang_cc1 -fmodules -fimplicit-module-maps -fmodules-cache-path=%t -F %S/Inputs %s -verify +// RUN: %clang_cc1 -fmodules -fimplicit-module-maps -F %S/Inputs %s -verify #include <Module/NotInModule.h> // expected-warning{{missing submodule 'Module.NotInModule'}} ---------------- Haven't checked the implementation but does the test cover any new behavior? Based on description it should test explicit modules. But the added line is testing `-fimplicit-module-maps`, just using the system-wide shared modules cache. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113775/new/ https://reviews.llvm.org/D113775 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits