carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land.
Looks good! I'm not sure if it's OK to write "dead tests" though (the one with the `TODO` comment). Would it make sense to remove it from this patch, and add it in the patch where the issue is fixed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113708/new/ https://reviews.llvm.org/D113708 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits