aprantl added a comment.
This looks reasonable to me. Thanks!
================
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:234
+ if (!LexicalBlockStack.empty())
+ LexicalBlockMap[&D] = LexicalBlockStack.back();
+}
----------------
maybe use `LexicalBlockMap.insert({&D, LexicalBlockStack.back()});` to make it
clear that we are not going to overwrite an entry?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113743/new/
https://reviews.llvm.org/D113743
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
