whisperity added inline comments.
================ Comment at: clang-tools-extra/clang-tidy/readability/ContainerContainsCheck.cpp:105-108 + const auto *PositiveCheck = Result.Nodes.getNodeAs<Expr>("positive"); + const auto *NegativeCheck = Result.Nodes.getNodeAs<Expr>("negative"); + bool Negated = NegativeCheck != nullptr; + const auto *Check = Negated ? NegativeCheck : PositiveCheck; ---------------- `Comparison` instead of `Check`? These should be matching the `binaryOperator`, right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112646/new/ https://reviews.llvm.org/D112646 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits