pengfei added a comment. > Disabled double or float return for x86 targets
Sorry, I think we still need to match GCC's behavior. I.e., we shouldn't diagnosticate any FP type (float, double, long double) on 32-bits. https://godbolt.org/z/KrbhfWc9o We have users who require of that. Noticed this problem during D112143 <https://reviews.llvm.org/D112143>. Could you have a look again? ================ Comment at: clang/test/Sema/x86-no-x87.cpp:1 +// RUN: %clang_cc1 -fsyntax-only -verify %s -triple i686-linux-gnu -target-feature -x87 -DRET_ERROR +// RUN: %clang_cc1 -fsyntax-only -verify %s -triple i686-linux-gnu -DNOERROR ---------------- This seems not used? ================ Comment at: clang/test/Sema/x86-no-x87.cpp:22-24 +// expected-error@+4{{'def' requires 'long_double' (aka 'long double') type support, but target 'i686-unknown-linux-gnu' does not support it}} +// expected-note@+3{{'def' defined here}} +// expected-note@+2{{'x' defined here}} ---------------- I'd think we can't emit error diagnostics on 32-bits now. We have users who rely on such behavior. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98895/new/ https://reviews.llvm.org/D98895 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
